Loki: Append loopback to ingester net interface default list #4570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanGuedes
force-pushed
the
add-lo-net-interface
branch
2 times, most recently
from
7934c2c
to
52c70f4
Compare
- Create new package `util/net` and puts `LoopbackInterfaceName` there - Modify distributor_test to use `util/net` package
- Append the loopback net interface to the list of net interfaces used by the ingester ring. The append only occurs if the ingester net interfaces are default - Add CHANGELOG entry
- Add tests to check the current net interface name resolution. The tests checks if the ingester ring net interface names are correctly copied to other rings
DylanGuedes
force-pushed
the
add-lo-net-interface
branch
from
52c70f4
to
0015618
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
LoopbackInterfaceNamefunction to a separateutil/netpackageWhich issue(s) this PR fixes:
Fixes #4483
Special notes for your reviewer:
Checklist