validate default limits config with other configs at startup #4573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should also parse and set the matchers in default stream retention config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also parse and set the matchers in default stream retention config
What this PR does / why we need it:
While investigating bug #4572, I noticed that we do not parse and populate matchers set in default stream retention which is done in Validate function. We call the
Validatefunction while loading per tenant overrides but not for the default config during startup. This PR takes care of the issue.I have also simplified validate function a bit by setting the matchers directly in the existing
StreamRetentionstruct instead of building the whole struct again.Which issue(s) this PR fixes:
Fixes #4572