Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unordered_writes by default #4594

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Oct 29, 2021

It's here! Unordered support for everyone, by default.

ref #1544

@DylanGuedes
Copy link
Contributor

DylanGuedes commented Oct 29, 2021

WDYT of adding this to the upgrading guide?

edit: I was thinking, maybe you can just add it to the existing "Change of some default limits to common values" section

@@ -2403,7 +2403,7 @@ configure a runtime configuration file:
```
overrides:
"tenantA":
unordered_writes: true
unordered_writes: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: what happens if global config unordered_writes is false (disabled), but per-tenant config unordered_writes is true (enabled).

this should still means disabled for that tenant?

Should we cover that case in the config doc somewere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tenant configs override globally set defaults. Yes this should be covered somewhere if it's not already 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarification! :)

@owen-d
Copy link
Member Author

owen-d commented Oct 29, 2021

WDYT of adding this to the upgrading guide?

It's never been in a release thus far, so I figured there's no action needed; writes will just succeed more often :)

Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very exciting!

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@owen-d owen-d merged commit 45113cb into grafana:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants