default ingester final sleep to 0 unless otherwise specified #4608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorwhitney
requested review from
dannykopping,
owen-d and
slim-bean
as code owners
|
Update the |
owen-d
approved these changes
Nov 1, 2021
trevorwhitney
force-pushed
the
default-final-sleep
branch
from
c586a45
to
aa17a1e
Compare
DylanGuedes
approved these changes
Nov 1, 2021
kavirajk
approved these changes
Nov 2, 2021
trevorwhitney
force-pushed
the
default-final-sleep
branch
from
aa17a1e
to
113f556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This changes the default value for the ingester lifecycler's final sleep from 30s to 0s. With the default value, loki appears to hang when shutting down. This feature is designed to allow one last metric scrape to occur before shutdown, but as that is heavily dependent on scrape intervals in various environments, this default value is probably not sensible for everyone. Furthermore, for users who don't even know this value exists, it may be surprising to them why Loki "hangs" on shut-down.
0sseems like a better default, as it won't delay the Loki shutdown, and the property is still available for users to set per their environment / scrape interval.Which issue(s) this PR fixes:
Fixes #4605
Checklist
CHANGELOG.mdabout the changes.