loki-mixin: fix label selectors + logs dashboard

[cstyan]

Simplify standard label selectors (datsource, cluster, namespace) on multiple dashboards + fix broken logs dashboard.

The logs dashboard seems to be completely broken without this PR, are we actively using it at all?

Signed-off-by: Callum Styan callumstyan@gmail.com

[cyriltovena]

LGTM

why did we remove templateLabels ? is it not used ?

[kavirajk]

LGTM! 👍

Q: Does this anyway break our internal dashboards or alerts (once its pulled it by /lib/loki-cloud-mixin)

[cstyan]

@cyriltovena why did we remove templateLabels ? is it not used ? The common template labels, cluster/namespace/logs datsource, are all defined in a common place that every dashboard can pull them in from dashboard-utils.libsonnet. Adding them to templating again manually causes problems.

@kavirajk Does this anyway break our internal dashboards or alerts (once its pulled it by /lib/loki-cloud-mixin) it shouldn't I tested this internally by modifying these same files but in our vendor directory. As usual, if you do see anything that's broken feel free to let me know.