Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont try to use the scheduler ring when a downstream url is configured #4635

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Nov 3, 2021

I can't see this being a reasonable configuration people would use, but when the scheduler is enabled (all, read, scheduler) targets, avoid using the scheduler ring when a downstream address is present in the frontend config, which would avoid any schedulers anyway.

@owen-d owen-d requested a review from a team as a code owner November 3, 2021 16:43
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, LGTM

@owen-d owen-d merged commit 0e0d0b7 into grafana:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants