Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dep to Go modules #571

Closed
wants to merge 19 commits into from
Closed

Move dep to Go modules #571

wants to merge 19 commits into from

Conversation

daixiang0
Copy link
Contributor

  • move to go mod
  • update CI config
  • add mod check

Signed-off-by: Xiang Dai 764524258@qq.com

@daixiang0
Copy link
Contributor Author

daixiang0 commented May 11, 2019

@gouthamve i do not know which version of corex should be used, mind help me?

@vtolstov
Copy link

any chance to merge this?

@daixiang0
Copy link
Contributor Author

@Kuqd @gouthamve mind have a look?

@daixiang0
Copy link
Contributor Author

@slim-bean mind have a look?

@cyriltovena
Copy link
Contributor

Can you make sure this is all up to date with the new Makefile and CI, I'm interested into having this.

@daixiang0
Copy link
Contributor Author

daixiang0 commented Aug 7, 2019

yep, i have merged master, all files are latest.

@cyriltovena
Copy link
Contributor

Hello @daixiang0 , Can you start a new document like this https://docs.google.com/spreadsheets/d/1AleBmoFtLtA-JWpfM77BHNxaOIAnj9JBmnr_7LJeWr8/edit#gid=0 so that we can access the risk.

Thank you, if you don't have time, I'll get to it when I'm free.

@daixiang0
Copy link
Contributor Author

daixiang0 commented Aug 8, 2019

@cyriltovena
Copy link
Contributor

should you update the vendor folder ? This would be helpful to see differences

@daixiang0
Copy link
Contributor Author

daixiang0 commented Sep 12, 2019

@cyriltovena @slim-bean Do you think we need to keep vendor folder after move to go modules? It may be build faster, but if removed, the whole size of repo would be minimized.

@daixiang0
Copy link
Contributor Author

There is network traffic in test environment... apt can not work,

@cyriltovena
Copy link
Contributor

I think we should keep vendor and build from it.

@daixiang0
Copy link
Contributor Author

@cyriltovena i have update based on master HEAD, but CI seems something wrong.
You can compare and check the changes in vendor.

@daixiang0
Copy link
Contributor Author

I run at local normally, i am sure it is a broken in CI env. @cyriltovena @slim-bean

Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
@daixiang0
Copy link
Contributor Author

@joe-elliott thanks for your job!
@cyriltovena i have rebased master(update very quickly recently), and all test pass!

Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
@daixiang0
Copy link
Contributor Author

CircleCI failed seems there is little resource to test since make lint is killed not exit 1. refer link

Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
@daixiang0
Copy link
Contributor Author

@cyriltovena ALL test pass!

@cyriltovena
Copy link
Contributor

Closing in favor of #1062

@daixiang0 daixiang0 deleted the mod branch October 1, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants