-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dep to Go modules #571
Conversation
@gouthamve i do not know which version of corex should be used, mind help me? |
any chance to merge this? |
@Kuqd @gouthamve mind have a look? |
adc4b00
to
0bcee9e
Compare
@slim-bean mind have a look? |
Can you make sure this is all up to date with the new Makefile and CI, I'm interested into having this. |
yep, i have merged master, all files are latest. |
Hello @daixiang0 , Can you start a new document like this https://docs.google.com/spreadsheets/d/1AleBmoFtLtA-JWpfM77BHNxaOIAnj9JBmnr_7LJeWr8/edit#gid=0 so that we can access the risk. Thank you, if you don't have time, I'll get to it when I'm free. |
should you update the vendor folder ? This would be helpful to see differences |
@cyriltovena @slim-bean Do you think we need to keep vendor folder after move to go modules? It may be build faster, but if removed, the whole size of repo would be minimized. |
2b82cdb
to
0d3ac03
Compare
There is network traffic in test environment... apt can not work, |
I think we should keep vendor and build from it. |
b428a51
to
70105ac
Compare
@cyriltovena i have update based on master HEAD, but CI seems something wrong. |
I run at local normally, i am sure it is a broken in CI env. @cyriltovena @slim-bean |
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
@joe-elliott thanks for your job! |
af7200c
to
6839220
Compare
Signed-off-by: Xiang Dai <764524258@qq.com>
25c4029
to
3ed5125
Compare
CircleCI failed seems there is little resource to test since make lint is killed not exit 1. refer link |
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
@cyriltovena ALL test pass! |
Closing in favor of #1062 |
Signed-off-by: Xiang Dai 764524258@qq.com