-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSDB/query-planning-groundwork #6367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
- querier/queryrange -1.2%
+ iter 0%
+ storage 0%
+ chunkenc 0%
- logql -0.2%
+ loki 0% |
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0.3%
+ querier 0%
- querier/queryrange -1.2%
+ iter 0%
+ storage 0%
+ chunkenc 0%
- logql -0.2%
+ loki 0% |
This PR does a few things that will prepare us for better query planning using the new
/loki/api/v1/index/stats
API:MatcherGroups()[][]*labels.Matcher
method to theSampleExpr
interface so we can resolve the underlying sets of stream matchers for metric queries. This will allow us to shard different legs of binary operations independently based on how much data each leg operates on.IndexStats{Request,Response}
so we can use them within the frontend middleware chains.ref #5428