Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component/integrations: rename fluent plugin #667

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

briangann
Copy link
Contributor

What this PR does / why we need it:

the current plugin name is already in use and published to rubygems.org

this change will rename ours to fluent-plugin-grafana-loki to differentiate it.

Which issue(s) this PR fixes:
Fixes #535

Special notes for your reviewer:

Checklist

  • [x ] Documentation added
  • Tests updated

@briangann briangann marked this pull request as ready for review June 14, 2019 09:07
@briangann
Copy link
Contributor Author

once this is merged we can publish the new gem

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena
Copy link
Contributor

@briangann do you have time to merge and publish the gem ? Or do you want to explain me how to do it ?

@briangann
Copy link
Contributor Author

I'll merge and publish it. Will also look at integrating publishing via circleci.

@briangann briangann merged commit 3b24a25 into master Jun 17, 2019
@briangann briangann deleted the 20190614_rename_fluent_plugin branch June 17, 2019 14:20
@briangann
Copy link
Contributor Author

published to rubygems: https://rubygems.org/gems/fluent-plugin-grafana-loki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fluent-plugin-loki - broken or very bad documentation?
2 participants