feat(logcli): extended tailing #737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs a regular query before tailing the websocket. This enables a more docker / kubectl like behaviour, which is what a regular users expects: A configurable amount of historic messages printed and new messages following up at the bottom. BREAKING: tailing now prints some historic log messages. Use `--count 0` to suppress.
There was a problem hiding this comment.
I see 2 problems here:
- It prints log entries received from non-tailing query in the descending order while tailing prints in ascending order.
- Entries pushed between non-tailing query and tail request would go missing.
For first as of now, there is no way to do a backward query and then print them in forward order.
I think the right way to implement this would be tail query itself doing this on the server. This would also keep behaviour same for other consumers of tail request not using logcli.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs a regular query before tailing the websocket.
This enables a more docker / kubectl like behaviour, which is what a regular user expects:
A configurable amount of historic messages printed and new messages following up at the bottom.
BREAKING: tailing now prints some historic log messages. Use
--count 0to suppress.Fixes #726