Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loki: removed unused TestGZIPCompression #858

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

pracucci
Copy link
Contributor

@pracucci pracucci commented Aug 6, 2019

What this PR does / why we need it:
The test TestGZIPCompression is currently skipped because of a missing fixture file. I've checked the test and the logic it tests looks already covered by other tests, so I'm proposing to remove the test to cleanup the test file and avoid misunderstandings.

Which issue(s) this PR fixes:
Fixes #829

Checklist

  • Documentation added
  • Tests updated

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 82a7eae into grafana:master Aug 6, 2019
@pracucci pracucci deleted the remove-unused-gzip-test branch August 7, 2019 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestGZIPCompression skipped
2 participants