ksonnet/loki: Add gRPC port to compactor mixin #8855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JoaoBraveCoding
force-pushed
the
compactor-add-grpc
branch
from
1b183b1
to
1e09a40
Compare
Merged
9 tasks
Problem: in grafana#7804 the possibility to use gRPC for communicating with compactor for query time filtering of data requested for deletion was added, however the loki mixin still generates the compactor service without a gRPC port. Solution: make the compactor service/deployment expose both a HTTP and gRPC port. Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>
JoaoBraveCoding
force-pushed
the
compactor-add-grpc
branch
from
1e09a40
to
7f7e016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Problem: in #7804 the possibility to use gRPC for communicating with the compactor for query time filtering of data requested for deletion was added, however, the loki mixin still generates the compactor service without a gRPC port.
Solution: make the compactor service/deployment expose both an HTTP and gRPC port.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdateddocs/sources/upgrading/_index.md