Fix panic in tailer when an ingester is removed from the ring while tailing #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
requested changes
Aug 14, 2019
pracucci
force-pushed
the
fix-tail-disconnected-ingesters
branch
from
70b419a
to
e89f9f1
Compare
|
@rfratto May you re-review the PR, please? Comments should have been addressed 🙏 |
rfratto
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If an ingester is removed from the ring while tailing,
tailDisconnectedIngesters()returns the tail clients map containing the removed ingester withnilvalue, causing a panic.Which issue(s) this PR fixes:
Fixes #845
Checklist