optimize image tag script #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
reviewed
Aug 19, 2019
tools/image-tag
Outdated
|
|
||
| # If this is a tag, use it, otherwise branch-hash |
There was a problem hiding this comment.
This indentation was on purpose, please leave it
There was a problem hiding this comment.
why need it? The comment in bash script seems no one to read.
tools/image-tag
Outdated
| @@ -5,9 +5,9 @@ set -o nounset | |||
| set -o pipefail | |||
|
|
|||
| WIP=$(git diff --quiet || echo '-WIP') | |||
| BRANCH=$(git rev-parse --abbrev-ref HEAD | sed s#/#-#g) | |||
| SHA=$(git rev-parse --short=7 HEAD | head -c7) | |||
There was a problem hiding this comment.
When 7 chars are not enough to be unique, git automatically uses more. We are forcing to 7 here, as we are doing for grafana/grafana as well.
There was a problem hiding this comment.
Get it. Add comment here is better i think.
Still perfer to add quota for sed.
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
daixiang0
force-pushed
the
remove-useless-pipe
branch
from
bf9516b
to
a39b154
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
man git rev-parseandman head, no need to runheadagain.Also,
sedshould better add quota.Signed-off-by: Xiang Dai 764524258@qq.com