pkg/logql: fix panic on invalid regex in matcher #951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
force-pushed
the
fix-logql-regex-panic
branch
2 times, most recently
from
ed71f8d
to
ffae7fa
Compare
loqgl.ParseExpr has been modified to use a defer/recover to recover from a panic caused by a failed regex parse in the parser. A defer and panic were used over adding an error return into mustNewMatcher by imitating how Go's parser works[1]: the exposed interface returns an error while the internal mechanisms use panic. This simplifies the design and implementation of the parser. Closes grafana#949. [1]: https://golang.org/src/go/parser/interface.go#L92
rfratto
force-pushed
the
fix-logql-regex-panic
branch
from
ffae7fa
to
5992af9
Compare
|
Do you need to rebase or the issue is fixed ? |
|
This is superseded by #654, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loqgl.ParseExprhas been modified to use a defer/recover to recover from a panic caused by a failed regex parse in the parser.A defer and panic were used over adding an error return into
mustNewMatcherby imitating how Go's parser works: the exposed interface returns an error while the internal mechanisms use panic. This simplifies the design and implementation of the parser.Fixes #949.