Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart: Add missing operator to promtail #967

Merged
merged 3 commits into from
Sep 24, 2019

Conversation

makocchi-git
Copy link
Contributor

The default toleration value in the promtail helm chart is missing operator and thereby promtail does not schedule correctly.
This PR fixes this scheduling issue.

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2019

CLA assistant check
All committers have signed the CLA.

@makocchi-git makocchi-git changed the title Add missing operator [promtail helm chart] helm chart: Add missing operator to promtail Sep 4, 2019
@cyriltovena
Copy link
Contributor

Hello @makocchi-git can you also bump the loki-stack chart please ?

@makocchi-git
Copy link
Contributor Author

@cyriltovena Sorry for my delay response. I rebased my branch and bumped loki-stack chart version too.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 54a27dc into grafana:master Sep 24, 2019
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
* Add missing operator

* Bump chart versions

* Bump chart versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants