Allow to pass max-size and max-file to the docker driver #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slim-bean
reviewed
Sep 5, 2019
| @@ -129,6 +132,8 @@ To specify additional logging driver options, you can use the --log-opt NAME=VAL | |||
| | `loki-tls-server-name` | No | | Name used to validate the server certificate. | |||
| | `loki-tls-insecure-skip-verify` | No | `false` | Allow to skip tls verification. | |||
| | `loki-proxy-url` | No | | Proxy URL use to connect to Loki. | |||
| | `max-size` | No | -1 | The maximum size of the log before it is rolled. A positive integer plus a modifier representing the unit of measure (k, m, or g). Defaults to -1 (unlimited). This is used by json-log required to keep the `docker log` command working. | |||
There was a problem hiding this comment.
should we default to unlimited? I would think something like 100m might be a better default, since most people are not going to want unlimited file growth a default of unlimited would mean everyone needs to configure this flag?
There was a problem hiding this comment.
This is the default for docker driver. https://docs.docker.com/config/containers/logging/json-file/
There was a problem hiding this comment.
Though I'm not against doing a better job.
There was a problem hiding this comment.
I think it makes sense to match the defaults of docker to remain consistent, although I don't feel strongly about this one way or the other
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
…ex-lookups"" This reverts commit 8b74f9053037c4590ec1512b65288e4869d5e748. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows docker driver users to control
max-fileandmax-sizeof the json-log driver used by Loki driver.I didn't remove the json-log as it allows users to keep using
docker logsin combination of Loki driver.What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #966
Special notes for your reviewer:
Checklist