This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
initialize ROB with correct metric interval #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
reviewed
Apr 10, 2019
mdata/aggregator.go
Outdated
| @@ -43,31 +43,31 @@ func NewAggregator(store Store, cachePusher cache.CachePusher, key schema.AMKey, | |||
| case conf.Avg: | |||
| if aggregator.sumMetric == nil { | |||
| key.Archive = schema.NewArchive(schema.Sum, span) | |||
| aggregator.sumMetric = NewAggMetric(store, cachePusher, key, conf.Retentions{ret}, 0, nil, dropFirstChunk) | |||
| aggregator.sumMetric = NewAggMetric(store, cachePusher, key, conf.Retentions{ret}, 0, 0, nil, dropFirstChunk) | |||
There was a problem hiding this comment.
why would we deliberately pass interval=0 and not the correct interval (span) ? even if we don't end up using the value in NewAggMetric() from these calls, this makes the code brittle and likely to break once we start using it for something else.
Dieterbe
force-pushed
the
fix_1196
branch
2 times, most recently
from
f1f3de0
to
a6145a7
Compare
|
I fixed up this PR. looks good to me now |
Dieterbe
changed the title
|
LGTM. I added a quick fix to address #1201 as well. |
woodsaj
approved these changes
Apr 10, 2019
Dieterbe
changed the title
|
moved your commit to #1276 |
Dieterbe
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not tested yet
fixes #1196