Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

mt-gateway docker compose #1644

Merged
merged 5 commits into from
Feb 12, 2020
Merged

mt-gateway docker compose #1644

merged 5 commits into from
Feb 12, 2020

Conversation

fitzoh
Copy link
Contributor

@fitzoh fitzoh commented Jan 28, 2020

Add mt-gateway docker-compose configuration to stacks that currently include tsdb-gw (docker-cosmosdb and docker-dev-custom-cfg-kafka).

While we will eventually want to remove the tsdb-gw configurations (and possibly move them to the tsdb-gw repo?) I have not done so yet, as there is nothing preventing them from running concurrently.

Also fixes an incorrect default port in mt-gateway.ini.

While I was able to verify metrics ingestion for the custom Kafka stack, I was not able to do so for the cosmos stack (no cosmos db available).

@Dieterbe
Copy link
Contributor

While we will eventually want to remove the mt-gateway configurations (and possibly move them to the mt-gateway repo?) I have not done so yet, as there is nothing preventing them from running concurrently.

huh? did you mean tsdb-gw?

@fitzoh
Copy link
Contributor Author

fitzoh commented Jan 28, 2020

huh? did you mean tsdb-gw?

bah, edited... and yes

@fitzoh fitzoh requested a review from a team January 28, 2020 19:24
MT_GRAPHITE_URL: http://metrictank:6060
MT_METRICS_PUBLISH: "true"
MT_METRICS_KAFKA_COMP: snappy
MT_KAFKA_TCP_ADDR: kafka:9092
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mt-gateway doesn't emit stats like tsdb-gw does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some instrumentation, but we don't currently have any configuration for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not? should be trivial. just copy over the code from tsdbgw?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hadn't come up yet (the initial goal was minimal functionality).
There's also a mix of graphite and prometheus instrumentation.

I can port it over

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in #1645, can rebase and update once that's merged.

Copy link
Contributor

@Dieterbe Dieterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just make sure to set up the needed docker links such that it can emit stats. the links section should probably be the same for tsdbgw and mt-gateway
then feel free to merge

@fitzoh
Copy link
Contributor Author

fitzoh commented Feb 12, 2020

rebased after merging #1645

@fitzoh fitzoh merged commit 76afed6 into master Feb 12, 2020
@fitzoh fitzoh deleted the mt-gateway-docker-compose branch February 12, 2020 04:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants