-
Notifications
You must be signed in to change notification settings - Fork 104
Conversation
huh? did you mean tsdb-gw? |
bah, edited... and yes |
MT_GRAPHITE_URL: http://metrictank:6060 | ||
MT_METRICS_PUBLISH: "true" | ||
MT_METRICS_KAFKA_COMP: snappy | ||
MT_KAFKA_TCP_ADDR: kafka:9092 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mt-gateway doesn't emit stats like tsdb-gw does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some instrumentation, but we don't currently have any configuration for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not? should be trivial. just copy over the code from tsdbgw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hadn't come up yet (the initial goal was minimal functionality).
There's also a mix of graphite and prometheus instrumentation.
I can port it over
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in #1645, can rebase and update once that's merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. just make sure to set up the needed docker links such that it can emit stats. the links section should probably be the same for tsdbgw and mt-gateway
then feel free to merge
f112756
to
d87c3db
Compare
rebased after merging #1645 |
Add mt-gateway docker-compose configuration to stacks that currently include tsdb-gw (
docker-cosmosdb
anddocker-dev-custom-cfg-kafka
).While we will eventually want to remove the
tsdb-gw
configurations (and possibly move them to thetsdb-gw
repo?) I have not done so yet, as there is nothing preventing them from running concurrently.Also fixes an incorrect default port in
mt-gateway.ini
.While I was able to verify metrics ingestion for the custom Kafka stack, I was not able to do so for the cosmos stack (no cosmos db available).