Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Kafka ssl support #1701

Merged
merged 10 commits into from
Mar 17, 2020
Merged

Kafka ssl support #1701

merged 10 commits into from
Mar 17, 2020

Conversation

Mixton
Copy link
Contributor

@Mixton Mixton commented Feb 28, 2020

Add SSL configuration options for Kafka clients as described in Shopify/sarama documentation.

@ahmet2mir ahmet2mir mentioned this pull request Mar 5, 2020
Closed
replay
replay suggested changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@replay replay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx for the contribution.
I only added a few very small suggestions for spelling fixes, after merging those the .ini files will also need to be updated to reflect those changes, then the PR should be good to merge.

input/kafkamdm/kafkamdm.go Outdated Show resolved Hide resolved
mdata/notifierKafka/cfg.go Outdated Show resolved Hide resolved
input/kafkamdm/kafkamdm.go Outdated Show resolved Hide resolved
mdata/notifierKafka/cfg.go Outdated Show resolved Hide resolved
Mixton and others added 2 commits March 7, 2020 08:21
@Mixton @replay
Apply suggestions from code review
07d8d6a 
Co-Authored-By: Mauro Stettler <mauro.stettler@gmail.com>
@Mixton
update ini/doc files
9b9f900
@Mixton
Copy link
Contributor Author

Mixton commented Mar 7, 2020

Hi Mauro,
Thanks for your time. Your changes was added and the conf/ini files updated. Ci is in progress. Let me know if you need something else.

@replay
Copy link
Contributor

replay commented Mar 17, 2020

thx @Mixton

replay
replay approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@replay replay merged commit 263ccaf into grafana:master Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@replay replay replay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mixton @replay