Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test running Mimir in read-write deployment mode #3363

Closed
5 tasks done
pracucci opened this issue Nov 2, 2022 · 4 comments · Fixed by #3799
Closed
5 tasks done

Add integration test running Mimir in read-write deployment mode #3363

pracucci opened this issue Nov 2, 2022 · 4 comments · Fixed by #3799
Assignees

Comments

@pracucci
Copy link
Collaborator

pracucci commented Nov 2, 2022

We should create an integration test to run Mimir in read-write deployment mode.


Cases / components to cover (see #3363 (comment)):

@charleskorn
Copy link
Contributor

I've got a first test up in #3423.

This first test just covers a very straightforward scenario of writing some data and then reading it back again.

I'm still getting to grips with the system and the implications of the different deployment modes, so I'm not sure what else would be valuable to test - I'm not sure what risks / concerns the different deployment modes introduce. For example, should we test that other functionality like the compactor, ruler or alert manager are working correctly? Are there other things that warrant an integration test?

@pracucci
Copy link
Collaborator Author

I'm still getting to grips with the system and the implications of the different deployment modes, so I'm not sure what else would be valuable to test - I'm not sure what risks / concerns the different deployment modes introduce. For example, should we test that other functionality like the compactor, ruler or alert manager are working correctly? Are there other things that warrant an integration test?

Good question! My take:

  • Focus on the differences between microservices and read-write deployment mode
  • The main difference is how components are packaged, so the most important thing to test for me is that components successfully start/run with -target=write/read/backend respectively
  • For this reason, I wouldn't test "features" (e.g. replication factor 3 vs 1) but more the "deployment" (can querier talk to ingesters? can querier query historical data from store-gateway?)

To answer your question, as a follow up of #3423 I would additionally test:

  • Store-gateway / compactor (keeping as simplest as possible)
  • Ruler (e.g. evaluate a recording rule)

@charleskorn
Copy link
Contributor

Once #3799 is merged, I think this is done - are there any other cases you think we need to cover @pracucci?

@pracucci
Copy link
Collaborator Author

Once #3799 is merged, I think this is done - are there any other cases you think we need to cover @pracucci?

No other cases we should cover. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants