Add metric for error codes resulting from forwarding requests #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
pracucci
reviewed
Jun 12, 2022
osg-grafana
reviewed
Jun 13, 2022
osg-grafana
reviewed
Jun 13, 2022
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
replay
deleted the
add_metric_for_error_codes_resulting_from_forwarding_requests
branch
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 11, 2022
…a#2077) * add metric for error codes resulting from forwarding requests Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * add unit test for forwarding errors Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * linter Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * PR feedback Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * key metric by target instead of user Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * improve help text Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * update tests to expect updated help string Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * updated to key by target Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * remove target and tenant labels Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to get insight into errors returned by forwarding targets, this adds a metric to track the errors by tenant and status code.