Fix label order when incrementing ingester discarded metadata metric #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr00se
force-pushed
the
fix-metadata-limit-labels
branch
from
0f5716c
to
47f6c2c
Compare
|
Nice find! Can we add a test for this change? |
pr00se
force-pushed
the
fix-metadata-limit-labels
branch
from
47f6c2c
to
1effdd8
Compare
|
Tests added. When writing them I discovered another bug where we were using the address of a loop variable (which is always the same) to append items to a list, resulting in a list of multiple copies of the same metadata, rather than a list of different metadatas. I shadowed the variable in the loop so we'd return the address of a copy of the data, but let me know if there's a different pattern we typically follow. |
pracucci
reviewed
Jun 16, 2022
| @@ -93,6 +93,7 @@ func (mm *userMetricsMetadata) toClientMetadata() []*mimirpb.MetricMetadata { | |||
| r := make([]*mimirpb.MetricMetadata, 0, len(mm.metricToMetadata)) | |||
| for _, set := range mm.metricToMetadata { | |||
| for m := range set { | |||
| m := m | |||
There was a problem hiding this comment.
Can we have a unit test covering this regression too, please?
pracucci
approved these changes
Jun 17, 2022
3 tasks
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 11, 2022
…rafana#2096) * Use proper label order when incrementing ingester discarded metadata metric * Update CHANGELOG * Shadow a loop variable so we can return its address * Add tests for metadata limits * Update CHANGELOG * Set replication factor to 1 in ingester tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Corrects the order of the labels applied when incrementing the
cortex_discarded_metadata_totalmetric in the ingesters. As defined in thevalidationpackage, the order should be(reason, user).Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]