Helm: enable multi-tenancy in OSS by default #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajorama
force-pushed
the
krajo/20220616-multitenancy-by-default
branch
5 times, most recently
from
810a502
to
710e96b
Compare
Disabled multi tenancy makes it look like OSS does not support it. Also it makes it harder to migrate to multi tenancy and/or GEM. Enable multi tenancy by default, but at the same time make sure that Nginx sets the X-Scope-OrgID to anonymous if it's missing. This is done for backwards compatibility and ease of use. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
force-pushed
the
krajo/20220616-multitenancy-by-default
branch
from
710e96b
to
5baa9d8
Compare
Logiraptor
approved these changes
Jun 16, 2022
|
This is great @krajorama ! I think you made the right call to remove the setting. Less options makes things easier to maintain and is less to take in for the user. @Logiraptor @krajorama -- did you validate that reading metrics back still works? I'm assuming nginx will also set the header on my read requests to anonymous if I send a read without a header? |
|
@09jvilla Yes, in my tests the query results were identical whether setting the tenant to |
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 11, 2022
Disabled multi tenancy makes it look like OSS does not support it. Also it makes it harder to migrate to multi tenancy and/or GEM. Enable multi tenancy by default, but at the same time make sure that Nginx sets the X-Scope-OrgID to anonymous if it's missing. This is done for backwards compatibility and ease of use. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Disabled multi tenancy makes it look like OSS does not support it.
Also it makes it harder to migrate to multi tenancy and/or GEM.
Enable multi tenancy by default, but at the same time make sure that
Nginx sets the X-Scope-OrgID to anonymous if it's missing. This is done
for backwards compatibility and ease of use.
I've removed the setting, because enabled is the default, but maybe we'd want to be explicit?
Which issue(s) this PR fixes or relates to
Fixes grafana/helm-charts#1334
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]