Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update memberlist. #2418

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Update memberlist. #2418

merged 2 commits into from
Jul 14, 2022

Conversation

pstibrany
Copy link
Member

What this PR does

This PR updates memberlist to latest version of grafana/memberlist@09ffed8.

This fixes #2401.

Checklist

  • [na] Tests updated
  • [na] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Hours and hours of debugging, to remove 2 lines of code 🤦

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Marco Pracucci <marco@pracucci.com>
@pstibrany pstibrany enabled auto-merge (squash) July 14, 2022 14:33
@pstibrany pstibrany merged commit 5da4c35 into main Jul 14, 2022
@pstibrany pstibrany deleted the update-memberlist branch July 14, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distributors not leaving the ring on shutdown when memberlist is used
2 participants