distributor: remove labels with empty values #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
dist-remove-empty-labels
branch
from
4ba73d7
to
de73c7d
Compare
pstibrany
approved these changes
Jul 18, 2022
CHANGELOG.md
Outdated
| @@ -18,6 +18,7 @@ | |||
| * [ENHANCEMENT] Object storage can now be configured for all components using the `common` YAML config option key (or `-common.storage.*` CLI flags). #2330 | |||
| * [ENHANCEMENT] Go: updated to go 1.18.4. #2400 | |||
| * [ENHANCEMENT] Store-gateway, listblocks: list of blocks now includes stats from `meta.json` file: number of series, samples and chunks. #2425 | |||
| * [ENHANCEMENT] Distributor: remove labels with empty values #2439 | |||
There was a problem hiding this comment.
Suggested change
| * [ENHANCEMENT] Distributor: remove labels with empty values #2439 | |
| * [ENHANCEMENT] Distributor: remove labels with empty values. #2439 |
pstibrany
reviewed
Jul 18, 2022
| @@ -506,6 +506,15 @@ func removeLabel(labelName string, labels *[]mimirpb.LabelAdapter) { | |||
| } | |||
| } | |||
|
|
|||
| // Remove labels with value=="" from a slice of LabelPairs, updating the slice in-place. | |||
| func removeEmptyLabelValues(labels *[]mimirpb.LabelAdapter) { | |||
| for i := len(*labels) - 1; i >= 0; i-- { | |||
There was a problem hiding this comment.
Could there be any performance difference when processing labels from the beginning vs from the end?
There was a problem hiding this comment.
I suspect the idea was if we have a, b, c, d, e and we're going to remove b and d, then going forwards means we copy d before removing it, whereas going backwards avoids that.
Also, going forward you need to not increment i if you removed an item.
bboreham
force-pushed
the
dist-remove-empty-labels
branch
from
de73c7d
to
6c59b05
Compare
pstibrany
approved these changes
Sep 23, 2022
|
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
Empty labels are stripped when the series reaches TSDB, so we should remove them earlier to keep things consistent.
bboreham
force-pushed
the
dist-remove-empty-labels
branch
from
6c59b05
to
e124e1c
Compare
|
Rebased against latest |
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
approved these changes
Dec 6, 2022
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
* distributor: remove labels with empty values Empty labels are stripped when the series reaches TSDB, so we should remove them earlier to keep things consistent. * Added more test cases Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty labels are stripped when the series reaches TSDB, so we should remove them earlier to keep things consistent.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]