-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add counter for chunks from ingesters entirely deduplicated #2713
Conversation
This comment has been minimized.
This comment has been minimized.
d840bc3
to
3221c3b
Compare
This comment has been minimized.
This comment has been minimized.
3221c3b
to
a1266f6
Compare
Add a counter for tracking the number of chunks that could be entirely discarded as duplicates of an existing chunk when querying ingesters. This is a requirement of testing distributor <-> ingester timeout changes. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
a1266f6
to
7f19509
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me. It would be nice to have a unit test for this change too.
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
I'm struggling to come up with a good way to test this without a lot of refactoring. Because this runs as an operation against the ring, it seems that the operation returns as soon as the required number of ingesters have responded. I've tried with 3 ingesters and RF=3 as well as 2 ingesters and RF=2. |
Perhaps adding a check into some integration test would be much simpler -- just see if the metric has expected value. But feel free to not block on the test. |
Add a counter for tracking the number of chunks that could be entirely discarded as duplicates of an existing chunk when querying ingesters. This is a requirement of testing distributor <-> ingester timeout changes. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
…2744) Add a counter for tracking the number of chunks that could be entirely discarded as duplicates of an existing chunk when querying ingesters. This is a requirement of testing distributor <-> ingester timeout changes. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
What this PR does
Add a counter for tracking the number of chunks that could be entirely discarded
as duplicates of an existing chunk when querying ingesters. This is a requirement
of testing distributor <-> ingester timeout changes.
Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]