Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version checking in mimirtool #2723

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Conversation

dimitarvdimitrov
Copy link
Contributor

Signed-off-by: Dimitar Dimitrov dimitar.dimitrov@grafana.com

What this PR does

Fixes a bug where version checking was broken

$ mimirtool version
Mimirtool, version 2.2.0 (branch: HEAD, revision: 65344e2ed)
  go version:       go1.17.8
  platform:         darwin/arm64
checking latest version... A newer version of mimirtool is available, please update to mimir-2.2.0

Also adds a link to the release

$ cmd/mimirtool/mimirtool version
Mimirtool, version 2.3.0 (branch: dimitar/fix-mimirtool-version-check, revision: 64c5aefa8)
  go version:       go1.18.4
  platform:         darwin/arm64
checking latest version... A newer version of mimirtool is available, please update to 2.2.0 https://github.com/grafana/mimir/releases/tag/mimir-2.2.0

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov dimitarvdimitrov added bug Something isn't working component/mimirtool labels Aug 15, 2022
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@krajorama krajorama self-requested a review August 15, 2022 13:56
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reproduced error, could not check fix because version is uknown in unreleased version

@pracucci pracucci merged commit e0b9f08 into main Aug 16, 2022
@pracucci pracucci deleted the dimitar/fix-mimirtool-version-check branch August 16, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/mimirtool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants