WIP: Metrics: Re-enable metrics removed in prometheus/client_golang 1.12.2 #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
chore/re-enable-metrics
branch
from
6e8cc43
to
2e8d2d4
Compare
aknuds1
changed the title
|
I'm a "no thanks" on this pending some specific justification why we need them. I could see adding a mechanism so they can be turned on when required. But again, someone has to actually need them. |
|
I agree with Bryan. We should re-enable such metrics only if (when) we have a real use case. |
|
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
~80 runtime metrics were removed in prometheus/client_golang 1.12.2. This PR re-adds them, as suggested by @dannykopping and discussed in Slack.
NB: It's still being discussed whether these metrics should be re-enabled or not.
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]