Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in -query-frontend.align-querier-with-step CLI flag #2840

Merged
merged 8 commits into from
Aug 26, 2022

Conversation

Rustin170506
Copy link
Contributor

@Rustin170506 Rustin170506 commented Aug 25, 2022

What this PR does

Fix typo in -query-frontend.align-querier-with-step CLI flag. Still keep the old one for backward compatibility.

Which issue(s) this PR fixes or relates to

Ref #2829

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@Rustin170506
Copy link
Contributor Author

The conflict has been resolved.

@pracucci pracucci self-requested a review August 26, 2022 12:31
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually tried it and it works great! Thanks! ❤️

pkg/frontend/querymiddleware/roundtrip.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci enabled auto-merge (squash) August 26, 2022 12:42
@pracucci pracucci merged commit ef55911 into grafana:main Aug 26, 2022
@Rustin170506
Copy link
Contributor Author

Thanks for your review! 💚 💙 💜 💛 ❤️

@Rustin170506 Rustin170506 deleted the rustin-patch-query-flag branch August 26, 2022 14:08
@pracucci
Copy link
Collaborator

Thanks for your review! 💚 💙 💜 💛 ❤️

All the opposite... thanks to YOU for all the great work you're doing. I'm impressed! Keep pushing 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants