Helm: open port 80 on enterprise gateway #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We opened 8080 by default default and this is kept as legacy. NOTEX.txt assumed we open port 80 by default, this is fixed by encoding 80 in the values file. Updated docstring. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
commented
Aug 29, 2022
...t-enterprise-configmap-values-generated/mimir-distributed/templates/gateway/gateway-svc.yaml
Show resolved
Hide resolved
dimitarvdimitrov
approved these changes
Aug 30, 2022
grafanabot
pushed a commit
that referenced
this pull request
Sep 7, 2022
* Helm: open port 80 on enterprise gateway We opened 8080 by default default and this is kept as legacy. NOTEX.txt assumed we open port 80 by default, this is fixed by encoding 80 in the values file. Updated docstring. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> (cherry picked from commit b9d1e9e)
krajorama
pushed a commit
that referenced
this pull request
Sep 7, 2022
* Helm: open port 80 on enterprise gateway We opened 8080 by default default and this is kept as legacy. NOTEX.txt assumed we open port 80 by default, this is fixed by encoding 80 in the values file. Updated docstring. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> (cherry picked from commit b9d1e9e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We opened 8080 by default default and this is kept as legacy.
NOTEX.txt assumed we open port 80 by default, this is fixed by encoding
80 in the values file.
Updated docstring.
Which issue(s) this PR fixes or relates to
Relates to: #2203
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]