Fix sanity check done on configured filesystem directories when running Alertmanager in microservices mode (#2947) #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng Alertmanager in microservices mode (#2947) * Fix sanity check done on configured filesystem directories when running Alertmanager in microservices mode Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> (cherry picked from commit bfad6ac)
pstibrany
approved these changes
Sep 14, 2022
pstibrany
reviewed
Sep 14, 2022
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| ### Grafana Mimir | |||
|
|
|||
| * [BUGFIX] Fix sanity check done on configured filesystem directories when running Alertmanager in microservices mode. #2947 | |||
There was a problem hiding this comment.
Changelog on the release branch should not mention main.
There was a problem hiding this comment.
But it does. I guess we'll fix it before publishing the stable version.
There was a problem hiding this comment.
But it does.
Yep. 😂 (It has nothing to do with this PR, I should have been more careful reviewing the other PR that introduced the change.)
jhesketh
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Cherry-picking the fix done in #2947.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]