Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve traces in distributor #3099

Merged
merged 5 commits into from
Sep 30, 2022
Merged

Improve traces in distributor #3099

merged 5 commits into from
Sep 30, 2022

Conversation

pstibrany
Copy link
Member

What this PR does

This PR adds extra log after incoming message in distributor has been unmarshalled, and adds tracing spans to distributor's forwarding code.

Checklist

  • [na] Tests updated
  • [na] Documentation added
  • [na] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pstibrany pstibrany requested a review from a team as a code owner September 30, 2022 15:20
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing but non-blocking superficial stuff.

pkg/distributor/forwarding/forwarding.go Outdated Show resolved Hide resolved
pkg/distributor/forwarding/forwarding.go Show resolved Hide resolved
pkg/util/http.go Outdated Show resolved Hide resolved
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany
Copy link
Member Author

Thanks for review Nick!

@pstibrany pstibrany enabled auto-merge (squash) September 30, 2022 15:54
@pstibrany pstibrany merged commit 10f6710 into main Sep 30, 2022
@pstibrany pstibrany deleted the improve-traces branch September 30, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants