store-gateway series: break up fetching of series into functions #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-983
to
-976
| s.metrics.seriesGetAllDuration.Observe(stats.getAllDuration.Seconds()) | ||
| s.metrics.seriesBlocksQueried.Observe(float64(stats.blocksQueried)) |
There was a problem hiding this comment.
This was also moved to recordSeriesCallResult
dimitarvdimitrov
force-pushed
the
dimitar/scplit-series-collection-from-series-sending
branch
from
67eaa19
to
ec5e732
Compare
pracucci
reviewed
Nov 28, 2022
replay
reviewed
Nov 28, 2022
pkg/storegateway/bucket.go
Outdated
| @@ -840,10 +840,8 @@ func (s *BucketStore) Series(req *storepb.SeriesRequest, srv storepb.Store_Serie | |||
|
|
|||
| var ( | |||
| ctx = srv.Context() | |||
| stats = &queryStats{} | |||
| stats *queryStats | |||
There was a problem hiding this comment.
is this declaration necessary? It just gets re-declared further down
There was a problem hiding this comment.
this should have been fixed with 0f75572
3 tasks
dimitarvdimitrov
added a commit
that referenced
this pull request
Nov 28, 2022
Series() acquires a per-tenant lock when starting to read from a block. The reason is to prevent a race between addBlock, removeBlock, and reading from these blocks (for example a block is unloaded after Series () has already selected it for querying; when accessing this block's index header we will be using an mmaped file which was deleted from disk). This PR moves this locking outside of Series() so we can use further simplify the code in PR 3540 (see [comment](#3540 (comment))) Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
added a commit
that referenced
this pull request
Nov 28, 2022
Series() acquires a per-tenant lock when starting to read from a block. The reason is to prevent a race between addBlock, removeBlock, and reading from these blocks (for example a block is unloaded after Series () has already selected it for querying; when accessing this block's index header we will be using an mmaped file which was deleted from disk). This PR moves this locking outside of Series() so we can use further simplify the code in PR 3540 (see [comment](#3540 (comment))) Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
This PR only moves code out of the Series method. It moved two functions - one that queries all blocks and one that updates metrics of the store-gateway from the stats of each Series method call Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
force-pushed
the
dimitar/scplit-series-collection-from-series-sending
branch
from
0f75572
to
1f015ec
Compare
pracucci
reviewed
Nov 29, 2022
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
deleted the
dimitar/scplit-series-collection-from-series-sending
branch
38 tasks
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
Series() acquires a per-tenant lock when starting to read from a block. The reason is to prevent a race between addBlock, removeBlock, and reading from these blocks (for example a block is unloaded after Series () has already selected it for querying; when accessing this block's index header we will be using an mmaped file which was deleted from disk). This PR moves this locking outside of Series() so we can use further simplify the code in PR 3540 (see [comment](grafana#3540 (comment))) Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…fana#3540) This PR only moves code out of the Series method. It moves two functions - one that queries all blocks and one that updates metrics of the store-gateway from the stats of each Series method call Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only moves code out of the Series method. It moved two functions -
one that queries all blocks and one that updates metrics of the
store-gateway from the stats of each Series method call