Deprecate blocks-storage.bucket-store.chunks-cache.subrange-size flag
#4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no value to changing the default and it's possible to introduce subtle performance problems by not using the default. See #4074 (comment) Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
replay
reviewed
Feb 2, 2023
replay
approved these changes
Feb 2, 2023
Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com
What this PR does
There's no benefit to changing the default and it's possible to introduce subtle performance problems by not using the default.
Which issue(s) this PR fixes or relates to
See #4074 (comment)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]