Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to requesting protobuf format on query path, and remove experimental status on flag #4557

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

charleskorn
Copy link
Contributor

What this PR does

This PR makes two related changes:

  • it makes the protobuf format the default format for the query path
  • it removes the experimental status on the -query-frontend.query-result-response-format flag

Note that this does not change the default or experimental status of the equivalent flag for the ruler-query-frontend -> ruler path, -ruler.query-frontend.query-result-response-format.

Which issue(s) this PR fixes or relates to

#4104

Checklist

  • [n/a] Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

The protobuf payload was too small to reach the configured limit.
@charleskorn charleskorn marked this pull request as ready for review March 22, 2023 05:18
@charleskorn charleskorn requested review from a team as code owners March 22, 2023 05:18
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I wonder if we could just switch to protobuf and remove the option since json doesn't work for histograms?

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

LGTM, I wonder if we could just switch to protobuf and remove the option since json doesn't work for histograms?

I think so, but I would wait until we run it longer in production (including the protobuf format in the ruler).

@pracucci pracucci merged commit 9344752 into main Mar 22, 2023
@pracucci pracucci deleted the charleskorn/protobuf-format-by-default branch March 22, 2023 07:57
@lamida lamida mentioned this pull request Apr 17, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants