Add configuration options to configure the "postings for matchers" cache of each compacted block queried from ingesters #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che of each compacted block queried from ingesters Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Mar 22, 2023
|
I've manually tested it (locally), and looks working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
While investigating the performance issues in the Mimir ingesters, due to some customer queries like
label=~".*"where the postings cache could significantly help but it doesn't help as much as I expected, I just realised that the settings I tuned for the postings cache in Mimir only apply to the TSDB head, but not the TSDB compacted blocks the customer queries also touch. So I've opened (and merged) a PR in mimir-prometheus to let the "postings for matchers" cache to be configurable for blocks too.In this PR I'm updating mimir-prometheus and exposing the config (experimental).
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]