Remove deprecation in redis jsonnet #4640
Conversation
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
There was a problem hiding this comment.
LGTM thanks! I just want to wait for @56quarters to see if he has any objection.
| @@ -88,7 +88,17 @@ | |||
|
|
|||
| * [CHANGE] Ruler: changed ruler deployment max surge from `0` to `50%`, and max unavailable from `1` to `0`. #4381 | |||
| * [CHANGE] Memcached connections parameters `-blocks-storage.bucket-store.index-cache.memcached.max-idle-connections`, `-blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections` and `-blocks-storage.bucket-store.metadata-cache.memcached.max-idle-connections` settings are now configured based on `max-get-multi-concurrency` and `max-async-concurrency`. #4591 | |||
| * [CHANGE] Add support to use external Redis as cache. #4386 | |||
| * [CHANGE] Add support to use external Redis as cache. Following are some changes in the jsonnet config: #4386 #4640 | |||
There was a problem hiding this comment.
The selection of settings mentioned here seems random (some enabled flags but not others, some item size flags but not others). Can we say that the various enabled flags have been renamed and the backend flags have been added since that a bit more accurately describes the change.
There was a problem hiding this comment.
I was trying to be more specific about the exact changes that we did. Can reordering the items in the bullet list help? If not I will apply your suggestion.
There was a problem hiding this comment.
I simplified the changelogs detail as suggested.
There was a problem hiding this comment.
The previous version of the CHANGELOG was offering better guidance. What if we say something like this:
- Renamed
memcached_*_enabledconfig options tocache_*_enabled - Renamed
memcached_*_max_item_size_mbconfig options tocache_*_max_item_size_mb - Added
cache_*_backendconfig options
There was a problem hiding this comment.
Updated with latest @pracucci suggestion.
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
What this PR does
Update #4386 with deprecation removal and detail of changed configs.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]