Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate binairies for freebsd #4654

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Conversation

wilfriedroset
Copy link
Collaborator

What this PR does

Add freebsd to the target OS when generating binaries for a Mimir release.

We are using nfpm to
package it for debian based and redhat based OS. nfpm does not support
packaging for freebsd, as such for freebsd users this is the best we can
do.

Which issue(s) this PR fixes or relates to

Fixes #4652

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@wilfriedroset wilfriedroset marked this pull request as ready for review April 3, 2023 11:28
@wilfriedroset wilfriedroset requested a review from a team as a code owner April 3, 2023 11:28
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo a comment about the CHANGELOG)

CHANGELOG.md Outdated Show resolved Hide resolved
…elease.

We are using [nfpm](https://nfpm.goreleaser.com/configuration/) to
package it for debian based and redhat based OS. nfpm does not support
packaging for freebsd, as such for freebsd users this is the best we can
do.

Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mimir release for FreeBSD
2 participants