jsonnet: set unregister_on_shutdown for store-gateway

[dimitarvdimitrov]

What this PR does

This was only set for the multi-zone StatefulSets, but the regular
StatefulSets could also benefit from less resharding during rollouts.

This is already being done in helm with #4690
so this PR also changes jsonnet.

Another option is to change the default value of the parameter in Mimir
itself.

Signed-off-by: Dimitar Dimitrov dimitar.dimitrov@grafana.com

Checklist

• Tests updated
• [n/a] Documentation added
• CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

[pracucci]

Another option is to change the default value of the parameter in Mimir
itself.

I discourage this because may make trying Mimir just a bit harder (need to manually forget store-gateways from the ring when scaling them down).

[dimitarvdimitrov]

I discourage this because may make trying Mimir just a bit harder (need to manually forget store-gateways from the ring when scaling them down).

FWIW the docs for scaling out mention this option. But maybe an extra step isn't desirable.

I don't have an opinion - this is more trying to keep jsonnet and helm in sync. If it's preferable to have this as true, then I can undo the change in helm.

[pracucci]

Another option is to change the default value of the parameter in Mimir
itself.

I discourage this because may make trying Mimir just a bit harder (need to manually forget store-gateways from the ring when scaling them down).

My comment was about changing the default value in Mimir. I think this PR is correct and we should keep jsonnet == Helm, which is unregister_on_shutdown = false.

[dimitarvdimitrov]

oh, sorry, i had overlooked that. In this case I'll merge this PR now. Thanks for the review