Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Upgrade to 1.20.3 #4773

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Go: Upgrade to 1.20.3 #4773

merged 1 commit into from
Apr 19, 2023

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Apr 19, 2023

What this PR does

Upgrade Go to 1.20.3.

Which issue(s) this PR fixes or relates to

Checklist

  • [na] Tests updated
  • [na] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 marked this pull request as ready for review April 19, 2023 10:57
@aknuds1 aknuds1 added the chore label Apr 19, 2023
@aknuds1 aknuds1 merged commit 5d9f104 into main Apr 19, 2023
@aknuds1 aknuds1 deleted the chore/upgrade-go-1203 branch April 19, 2023 11:18
krajorama pushed a commit that referenced this pull request Apr 20, 2023
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
krajorama added a commit that referenced this pull request Apr 20, 2023
* Go: Upgrade to 1.20.3 (#4773)

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

* storegw: Fix flaky test using pointer compare (#4785)

* storegw: Fix flaky test using pointer compare

Convert items to list of strings to avoid any pointers.

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@grafanabot
Copy link
Contributor

The backport to release-2.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-4773-to-release-2.8 origin/release-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 5d9f1048119156d2fbc3885d8b8b8bb59a858a35
# Push it to GitHub
git push --set-upstream origin backport-4773-to-release-2.8
git switch main
# Remove the local backport branch
git branch -D backport-4773-to-release-2.8

Then, create a pull request where the base branch is release-2.8 and the compare/head branch is backport-4773-to-release-2.8.

lamida pushed a commit that referenced this pull request Apr 20, 2023
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
(cherry picked from commit 5d9f104)
@lamida lamida mentioned this pull request Apr 20, 2023
3 tasks
krajorama added a commit that referenced this pull request Apr 20, 2023
* Go: Upgrade to 1.20.3 (#4773)

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
(cherry picked from commit 5d9f104)

* Remove main unreleased from changelog

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Add rc.1 section and fixup changelog

Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants