Salvacorts/update dskit #4833
Merged
Salvacorts/update dskit #4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
colega
approved these changes
Apr 25, 2023
colega
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Newer versions of
ring.GetInstanceAddrfrom theringpackage in dskit require a new argument to enable IPv6 support.This PR bumps the dskit version and updates the ring configuration with a new field to enable IPv6.
Which issue(s) this PR fixes or relates to
GEL uses the backend enterprise libs and Loki under the hood. Since Loki uses a newer version of dskit than the backend enterprise libs, we cannot update the Loki libs in GEL (example of failing CI job).
In order to bump the dskit version in the backend enterprise libs, we also need to update the dskit version in Mimir as the backend enterprise libs imports Mimir as a vendor (example of failing CI job).
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]