Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default regex size limit for query sharding to 4k #4932

Merged
merged 2 commits into from
May 5, 2023

Conversation

56quarters
Copy link
Contributor

What this PR does

Setting the limit disables query sharding for queries that have long regex matchers. Previous value was 0 (not enforced).

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Setting the limit disables query sharding for queries that have long
regex matchers. Previous value was 0 (not enforced).

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@pracucci pracucci self-requested a review May 5, 2023 02:37
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We've seen it beneficial at Grafana Labs and I think we should upstream it.

CHANGELOG.md Outdated Show resolved Hide resolved
@56quarters 56quarters marked this pull request as ready for review May 5, 2023 13:09
@56quarters 56quarters requested review from a team as code owners May 5, 2023 13:09
Co-authored-by: Marco Pracucci <marco@pracucci.com>
@56quarters 56quarters merged commit 5670ce9 into main May 5, 2023
@56quarters 56quarters deleted the 56quarters/default-sharding-regex-size branch May 5, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants