Helm: allow scheduling multiple pods from same zone on same node #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
thanks for addressing my feedback from #5018 We have a few committed manifests in the repo so it's easier to keep track of effects of changes to the chart. The CI is failing because these manifests are out of date since your change. You can update them by running |
|
Thanks, i have updated the tests. |
dimitarvdimitrov
approved these changes
May 17, 2023
There was a problem hiding this comment.
LGTM, thanks for the contribution. I think it would be great to also get @krajorama's feedback on this
dimitarvdimitrov
changed the title
krajorama
reviewed
May 17, 2023
operations/helm/charts/mimir-distributed/templates/_helpers.tpl
Outdated
Show resolved
Hide resolved
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
|
Thanks, i merged your suggestion. |
|
Can this be merged? |
krajorama
approved these changes
Jun 1, 2023
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #5018
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]