Enable streaming chunks from store-gateways to queriers by default #6646
Conversation
charleskorn
changed the title
|
Putting back to draft while I investigate failures in the |
There was a problem hiding this comment.
LGTM, glad to see this feature moving forward :)
The caching changes make sense to me. The only suggestions I left are to clarify the comments because it took me some time to get into this code again; maybe more verbose comments make this easier next time around
|
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
charleskorn
force-pushed
the
charleskorn/store-gateway-chunks-streaming-by-default
branch
from
23602e3
to
7ba1472
Compare
# Conflicts: # cmd/mimir/help-all.txt.tmpl # docs/sources/mimir/configure/about-versioning.md # pkg/querier/querier.go
# Conflicts: # CHANGELOG.md
…st with store-gateway chunks streaming enabled.
…eRunningInSingleBinaryMode
# Conflicts: # integration/querier_test.go
charleskorn
force-pushed
the
charleskorn/store-gateway-chunks-streaming-by-default
branch
from
95ae131
to
91646ed
Compare
|
#8039 has been running in production at Grafana for a few weeks now without any issues, so I think this is good to go now 🎉 |
charleskorn
deleted the
charleskorn/store-gateway-chunks-streaming-by-default
branch
What this PR does
Similar to #6174, this PR enables streaming chunks from store-gateways to queriers by default.
This feature has been enabled in production at Grafana Labs for quite some time now, and we've had no issues with it.
I've left the option to enable / disable this feature as experimental so that we can remove it in 2.14 and always prefer streaming chunks.
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]