wip: do not pick ingester with basic lifecycler #684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajorama
force-pushed
the
krajo/ingester-with-basic-lifecycler
branch
from
e478d94
to
cc094d5
Compare
krajorama
changed the title
krajorama
force-pushed
the
krajo/ingester-with-basic-lifecycler
branch
2 times, most recently
from
0aa538d
to
008c6dd
Compare
This commit explores how to use ring/BasicLifecycler in ingesters intead of the ring/Lifecycler.
krajorama
force-pushed
the
krajo/ingester-with-basic-lifecycler
branch
from
008c6dd
to
5563cbe
Compare
|
This is a copy-paste message. I've just cut the CHANGELOG in preparation to Mimir 2.0.0 release. Could you rebase |
|
|
2 tasks
|
@dimitarvdimitrov test GH notifty |
|
I'm closing it since it's stale. We can re-open it anytime, if / when we'll get back to this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT PICK/MERGE
What this PR does:
This commit explores how to use ring/BasicLifecycler in ingesters intead
of the ring/Lifecycler.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]