Report gRPC status codes as labels in request duration metrics #7144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duricanikolic
force-pushed
the
yuri/grpc-errors
branch
4 times, most recently
from
34f767e
to
3eecf06
Compare
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/grpc-errors
branch
from
3eecf06
to
7b3fca0
Compare
pstibrany
approved these changes
Jan 17, 2024
pracucci
reviewed
Jan 17, 2024
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR does the following things:
dskit'sserver.Config.ReportGRPCCodesInInstrumentationLabelto true, making ingester report gRPC status codes asstatus_codelabels in the ``cortex_request_duration_seconds` metric by default.status_codelables incortex_ingester_client_request_duration_secondsmetric by default.ingester.client.report-grpc-codes-in-instrumentation-label-enabledCLI flag, and sets its default value totrue. This CLI flag will be removed in Mimir 2.14.0, but the default behaviour of Mimir will be as the CLI flag were set totrue.Which issue(s) this PR fixes or relates to
Part of #6008
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.