Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't load series multiple times when streaming chunks from store-gateways and only one batch is needed #8039

Merged
merged 45 commits into from
May 23, 2024
Merged

Don't load series multiple times when streaming chunks from store-gateways and only one batch is needed #8039

merged 45 commits into from
May 23, 2024

Commits on Mar 19, 2024

  1. Fix outdated comment

    @charleskorn @zenador
    charleskorn authored and zenador committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    897d3b6 View commit details
    Browse the repository at this point in the history

  2. Add initial support for resetting loadingSeriesChunkRefsSetIterator

    @charleskorn @zenador
    charleskorn authored and zenador committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    254b1db View commit details
    Browse the repository at this point in the history

  3. Add important TODO

    @charleskorn @zenador
    charleskorn authored and zenador committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4f67084 View commit details
    Browse the repository at this point in the history

  4. add reset funcs in preparation but don't use them yet

    @zenador
    zenador committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    3fa6e3f View commit details
    Browse the repository at this point in the history

  5. reuse the iterator, this builds but fails tests with EOF

    @zenador
    zenador committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    05e6274 View commit details
    Browse the repository at this point in the history

  6. try changing strategy up front

    @zenador
    zenador committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    a15a25e View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Correctly reset merging and deduplicating iterators

    @charleskorn
    charleskorn committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    17c8360 View commit details
    Browse the repository at this point in the history

  2. Avoid counting series and chunks twice in limiting iterator

    @charleskorn
    charleskorn committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2473ca1 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Don't allow releasing series chunk refs set that will be reused

    @charleskorn
    charleskorn committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    4f4d20b View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Restore previous test setup

    @charleskorn
    charleskorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1542ebe View commit details
    Browse the repository at this point in the history

  2. Fix typo in variable name

    @charleskorn
    charleskorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    09ddd2e View commit details
    Browse the repository at this point in the history

  3. Restore more previous test setup

    @charleskorn
    charleskorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    fb1322b View commit details
    Browse the repository at this point in the history

  4. Restore use of noChunkRefs where it should be used, and remove outdat… 

    …ed comments.
    @charleskorn
    charleskorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e1eadbd View commit details
    Browse the repository at this point in the history

  5. Fix linting warning.

    @charleskorn
    charleskorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    676349d View commit details
    Browse the repository at this point in the history

  6. Introduce seriesIteratorStrategy flag for chunks streaming

    @charleskorn
    charleskorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c3fb275 View commit details
    Browse the repository at this point in the history

  7. Refactor test to exercise case where chunks streaming is both enabled… 

    … and disabled
    @charleskorn
    charleskorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8b81435 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Return reused series set to pool

    @charleskorn
    charleskorn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    4471f33 View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @charleskorn
    charleskorn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    afebea2 View commit details
    Browse the repository at this point in the history

  3. Only load chunk refs when they're needed.

    @charleskorn
    charleskorn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5915c19 View commit details
    Browse the repository at this point in the history

  4. Rename variable to make intent clearer

    @charleskorn
    charleskorn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f2dccc7 View commit details
    Browse the repository at this point in the history

  5. Add changelog entry

    @charleskorn
    charleskorn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    103615e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into charleskorn/store-gateway-double-work-fix

    @charleskorn
    charleskorn authored May 13, 2024
    Configuration menu
    Copy the full SHA
    73def47 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Rename withoutNoChunkRefs to withChunkRefs

    @charleskorn
    charleskorn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    9f40abc View commit details
    Browse the repository at this point in the history

  2. Remove redundant if

    @charleskorn
    charleskorn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    3c8e50f View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Add iterator type that wraps an iterator factory to manage the transi… 

    …tion between chunks streaming phases.
    @charleskorn
    charleskorn committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4f07071 View commit details
    Browse the repository at this point in the history

  2. Remove Reset methods

    @charleskorn
    charleskorn committed May 15, 2024
    Configuration menu
    Copy the full SHA
    cc40e1c View commit details
    Browse the repository at this point in the history

  3. Remove makeReleasable

    @charleskorn
    charleskorn committed May 15, 2024
    Configuration menu
    Copy the full SHA
    61290ed View commit details
    Browse the repository at this point in the history

  4. Unpick more unnecessary changes

    @charleskorn
    charleskorn committed May 15, 2024
    Configuration menu
    Copy the full SHA
    5f0342c View commit details
    Browse the repository at this point in the history

  5. Unpick whitespace change

    @charleskorn
    charleskorn committed May 15, 2024
    Configuration menu
    Copy the full SHA
    b24982d View commit details
    Browse the repository at this point in the history

  6. Extract method

    @charleskorn
    charleskorn committed May 15, 2024
    Configuration menu
    Copy the full SHA
    814d627 View commit details
    Browse the repository at this point in the history

  7. Refactor existing code to use `chunksStreamingCachingSeriesChunkRefsS… 

    …etIterator`
    @charleskorn
    charleskorn committed May 15, 2024
    Configuration menu
    Copy the full SHA
    77ac30b View commit details
    Browse the repository at this point in the history

  8. Fix issue where streaming chunks does not work if multiple batches of… 

    … series are loaded
    @charleskorn
    charleskorn committed May 15, 2024
    Configuration menu
    Copy the full SHA
    43115a9 View commit details
    Browse the repository at this point in the history

  9. Rename methods to better reflect their purpose

    @charleskorn
    charleskorn committed May 15, 2024
    Configuration menu
    Copy the full SHA
    3c5eefe View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Move streamingSeriesIterators to series_refs_streaming.go

    @charleskorn
    charleskorn committed May 20, 2024
    Configuration menu
    Copy the full SHA
    93b6d9f View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary comments

    @charleskorn
    charleskorn committed May 20, 2024
    Configuration menu
    Copy the full SHA
    c92b9a3 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary test helper function

    @charleskorn
    charleskorn committed May 20, 2024
    Configuration menu
    Copy the full SHA
    6ca5bc9 View commit details
    Browse the repository at this point in the history

  4. Introduce seriesChunkRefsIteratorWrapper interface instead of passi… 

    …ng function handles around, remove more unnecessary comments
    @charleskorn
    charleskorn committed May 20, 2024
    Configuration menu
    Copy the full SHA
    17bb03c View commit details
    Browse the repository at this point in the history

  5. Rename type

    @charleskorn
    charleskorn committed May 20, 2024
    Configuration menu
    Copy the full SHA
    81b1975 View commit details
    Browse the repository at this point in the history

  6. Make a copy of the postings for each phase.

    @charleskorn
    charleskorn committed May 20, 2024
    Configuration menu
    Copy the full SHA
    60f3084 View commit details
    Browse the repository at this point in the history

  7. Clarify comment

    @charleskorn
    charleskorn committed May 20, 2024
    Configuration menu
    Copy the full SHA
    c0fb6e9 View commit details
    Browse the repository at this point in the history

  8. Use concrete type

    @charleskorn
    charleskorn committed May 20, 2024
    Configuration menu
    Copy the full SHA
    e3d16b1 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into charleskorn/store-gateway-double-work-fix

    @charleskorn
    charleskorn authored May 20, 2024
    Configuration menu
    Copy the full SHA
    57c4b6b View commit details
    Browse the repository at this point in the history

  10. Don't make a copy of the postings unnecessarily.

    @charleskorn
    charleskorn committed May 20, 2024
    Configuration menu
    Copy the full SHA
    e711d49 View commit details
    Browse the repository at this point in the history

  11. Fix linting issues

    @charleskorn
    charleskorn committed May 20, 2024
    Configuration menu
    Copy the full SHA
    b2f7f15 View commit details
    Browse the repository at this point in the history

  12. Remove unused method

    @charleskorn
    charleskorn committed May 20, 2024
    Configuration menu
    Copy the full SHA
    1af591f View commit details
    Browse the repository at this point in the history