Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the 'for' period configurable for for InconsistentRuntimeConfig … #8173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kanica-g
Copy link

What this PR does

Currently, the for period is hardcoded, which may not be suitable for all deployment scenarios. Making this value configurable allows for greater flexibility and can accommodate different deployment strategies.

Which issue(s) this PR fixes or relates to

Fixes #8172

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@kanica-g kanica-g requested a review from a team as a code owner May 22, 2024 15:38
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pracucci
Copy link
Collaborator

pracucci commented Jun 7, 2024

See comment here, please: #8172 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the 'for' period configurable for MimirInconsistentRuntimeConfig alert
3 participants