-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mixins): disk space utilization panels #8212
fix(mixins): disk space utilization panels #8212
Conversation
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
9435d35
to
c843ae6
Compare
Hey @ying-jeanne thanks for the fast feedback. That is correct but the |
Hi thanks for the contribution, going through the changelog of kube-state-metrics, the label and annotation metrics are not deprecated but deactivated by default, during we are reviewing the PR, you can use --metric-labels-allowlist to explicitly export the related metrics. |
Just saw you attached conversation with Dimitar, tested some of the queries, they work as expected. Since he has already context on it, I would leave him for the review. |
@dimitarvdimitrov do you think you could check this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! Thank you very much 🙌
* fix(mixins): disk space utilization panels * add changelog entry Signed-off-by: QuentinBisson <quentin@giantswarm.io> --------- Signed-off-by: QuentinBisson <quentin@giantswarm.io>
What this PR does
This PR fixes the disk space utilization panels which are not working when running with a kube-state-metrics version >= 2.10 because of missing kube_persistentvolumeclaims_labels metrics
Which issue(s) this PR fixes or relates to
Fixes #7515
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.